Re: C/C++ PATCH for c/77423 (bogus warning with -Wlogical-not-parentheses)

[Bernd Schmidt <bschmidt at redhat dot com>]

On 09/05/2016 12:52 PM, Marek Polacek wrote:
> On Mon, Sep 05, 2016 at 12:35:13PM +0200, Bernd Schmidt wrote:
> > On 09/02/2016 05:13 PM, Marek Polacek wrote:
> > > diff --git gcc/doc/invoke.texi gcc/doc/invoke.texi
> > > index 87da1f1..38d55d4 100644
> > > --- gcc/doc/invoke.texi
> > > +++ gcc/doc/invoke.texi
> > > @@ -5437,8 +5437,8 @@ if (a < 0 && a < 0) @{ @dots{} @}
> > >  @opindex Wlogical-not-parentheses
> > >  @opindex Wno-logical-not-parentheses
> > >  Warn about logical not used on the left hand side operand of a comparison.
> > > -This option does not warn if the RHS operand is of a boolean type.  Its
> > > -purpose is to detect suspicious code like the following:
> > > +This option does not warn if the right operand is considered to be a Boolean
> > > +expression.  Its purpose is to detect suspicious code like the following:
> >
> > I think "Boolean" shouldn't be capitalized. The patch looks ok to me
> > otherwise.
>
> No strong opinions, but looking at
> https://en.wikipedia.org/wiki/Boolean_expression
> I see that it's capitalized there, so I think let's keep "Boolean".

I looked at other occurrences in this file, and they are lower-case. 
Across the other texi files upper-case is also the exception. Let's ask 
Sandra for a ruling?


Bernd