This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][Aarch64][gcc] Fix vld2/3/4 on big endian systems

From: Tamar Christina <tamar dot christina at arm dot com>
To: Christophe Lyon <christophe dot lyon at linaro dot org>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, James Greenhalgh <James dot Greenhalgh at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, nd <nd at arm dot com>
Date: Tue, 30 Aug 2016 17:45:48 +0100
Subject: Re: [PATCH][Aarch64][gcc] Fix vld2/3/4 on big endian systems
Authentication-results: sourceware.org; auth=none
Nodisclaimer: True
References: <AM4PR0802MB2274FAFBB8503AF287D25A11FF150@AM4PR0802MB2274.eurprd08.prod.outlook.com> <CAKdteOaEbyo19bcLFQo3fOC81azUHaVHc51OU0fb0yiOJgOwog@mail.gmail.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99



On 30/08/16 17:11, Christophe Lyon wrote:

On 18 August 2016 at 11:15, Tamar Christina <Tamar.Christina@arm.com> wrote:

Hi all,

This fixes a bug in the vector load functions in which they load the
vector in the wrong order for big endian systems. This patch flips the
order conditionally in the vec_concats.

No testcase given because plenty of existing tests for vld functions.
Ran regression tests on aarch64_be-none-elf and aarch64-none-elf.
Vldx tests now pass on aarch64_be-none-elf and no regressions on both.

Before your patch, I can see aarch64/vldN_1.c and
aarch64/advsimd-intrinsics/vldX_lane.c failing.

Do you know why aarch64/advsimd-intrinsics/vldX.c and vldX_dup
are not failing?

That's weird, on my clean build and our nightlies I see

aarch64/advsimd-intrinsics/vldX.c, aarch64/advsimd-intrinsics/vtbX.c andaarch64/vldN_1.c failing but

aarch64/advsimd-intrinsics/vldX_lane.c is passing.

I don't know why the vldX_lane was passing, but I'll look into thediscrepancy.


Cheers,
Tamar

Thanks
Christophe

Ok for trunk?

I do not have commit rights so if ok can someone apply it for me?

Thanks,
Tamar

gcc/
2016-08-16  Tamar Christina  <tamar.christina@arm.com>

         * gcc/config/aarch64/aarch64-simd.md
         (aarch64_ld2<mode>_dreg_le): New.
         (aarch64_ld2<mode>_dreg_be): New.
         (aarch64_ld2<mode>_dreg): Removed.
         (aarch64_ld3<mode>_dreg_le): New.
         (aarch64_ld3<mode>_dreg_be): New.
         (aarch64_ld3<mode>_dreg): Removed.
         (aarch64_ld4<mode>_dreg_le): New.
         (aarch64_ld4<mode>_dreg_be): New.
         (aarch64_ld4<mode>_dreg): Removed.
         (aarch64_ld<VSTRUCT:nregs><VDC:mode>): Wrapper around _le, _be.

References:
- [PATCH][Aarch64][gcc] Fix vld2/3/4 on big endian systems
  - From: Tamar Christina
- Re: [PATCH][Aarch64][gcc] Fix vld2/3/4 on big endian systems
  - From: Christophe Lyon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]