This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Simplify dg-options for tests using pthreads
Hi Jonathan,
>>The next step would be to replace the explict target list with an
>>effective-target keyword ;-)
>
> Yes, I've started doing that in a local branch, so we'd use something
> like:
>
> { dg-do run { target libstdc++-threads-supported } }
> { dg-add-options libstdc++-threads-flags }
>
> Where that would only run the test where supported, and would add
> -pthread if the target needs it.
good. However, those are quite a mouthful. Why not just use pthread
for both keywords (the namespaces are disjunct), or even omit
dg-add-options if -pthread works everywhere "target pthread" does? The
keywords are supposed to name the feature itself; -supported and -flags
are redundant and I have a hard time believing there's something
libstdc++ specific in there.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University