This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2][v4] Drop excess size used for run time allocated stack variables.
- From: Jeff Law <law at redhat dot com>
- To: vogt at linux dot vnet dot ibm dot com, gcc-patches at gcc dot gnu dot org, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Thu, 18 Aug 2016 10:20:38 -0600
- Subject: Re: [PATCH 2/2][v4] Drop excess size used for run time allocated stack variables.
- Authentication-results: sourceware.org; auth=none
- References: <20160429221242.GA2205@linux.vnet.ibm.com> <e128d673-061b-5b9a-90ef-84613093bf90@redhat.com> <20160503141753.GA17351@linux.vnet.ibm.com> <20160525133054.GA6938@linux.vnet.ibm.com> <20160525133241.GB6938@linux.vnet.ibm.com> <0d821ecb-89bb-06e4-fbce-501e59d418f8@redhat.com> <20160623095741.GA9623@linux.vnet.ibm.com> <59557a2d-0a6c-46d5-8e0a-02b7845c8734@redhat.com> <20160722095522.GA24126@linux.vnet.ibm.com> <20160726155317.GA5718@linux.vnet.ibm.com>
On 07/26/2016 09:53 AM, Dominik Vogt wrote:
Finally a patch that works and is simple. Bootstrapped and
regression tested on s390, s390x biarch and x86_64. The new patch
exploits the known alignment of (stack pointer +
STACK_DYNAMIC_OFFSET) as described earlier (see below). I think
that is the right way to get rid of the extra allocation. It
took a long time to understand the problem.
As the patch triggers a bug in the fortran compiler, the
der_type.f90 test case may fail on some targets if this patch is
used without the fortran fix that I've posted in another thread.
(The patch also contains a fix for a typo in a comment in the
patched function.)
See ChangeLog for a full description of the new patch.
Since the patch is all new, we're not going to commit it without a
new OK.
I like this one much better :-)
OK.
Thanks for your patience,
JEff