This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BUILDROBOT] avr broken

On 08/16/16 08:49, Martin Liška wrote:

On 08/13/2016 02:14 PM, Jan-Benedict Glaw wrote:

This doesn't work for AVR since their LONG_LONG_TYPE_SIZE depents on
target flags (see eg. build
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=602648)


Hello.

Sorry for the breakage, I haven't tried to build avr target for the patch.
I'm sending a candidate patch which survives regression tests on ppc64le-redhat-linux.
Apart from that, cc1 can be built with --target=avr-linux.

Ready to be installed?
Martin



is LONG_LONG_TYPE_SIZE something not suitable for a #if on avr?
presuming that's the problem, I think this approach is fine. I did have a think about putting the 32/64 bit check in one place rather than the two places it is. But (a) that's overkill and (b) it's in 2 places already. 

So this is ok, of it's ok from AVR's POV.

nathan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]