This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix early debug regression with DW_AT_string_length (PR debug/71906)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Aldy Hernandez <aldyh at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 12 Aug 2016 19:57:42 +0200
- Subject: Re: [PATCH] Fix early debug regression with DW_AT_string_length (PR debug/71906)
- Authentication-results: sourceware.org; auth=none
- References: <20160721165324.GI7387@tucnak.redhat.com> <d6c8deb9-958e-09e4-194c-dcce248da819@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Aug 12, 2016 at 01:47:14PM -0400, Jason Merrill wrote:
> On 07/21/2016 12:53 PM, Jakub Jelinek wrote:
> > size = int_size_in_bytes (TREE_TYPE (szdecl));
> ...
> >+ if (size != DWARF2_ADDR_SIZE)
> >+ add_AT_unsigned (array_die, DW_AT_byte_size, size);
>
> For DWARF5, where DW_AT_byte_size is always the size of the array type, I
> think this should be DW_AT_string_length_byte_size.
Sure, but this is just reindenting existing code,
DW_AT_string_length_byte_size isn't yet in dwarf2.def nor anywhere else.
When DWARF5 will make it into the public beta, I'll try to spend some time
on implementing the 5 support, but I think it would be better done
incrementally then, not part of this patch.
Jakub