This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: A few more fallthrus
- From: Marek Polacek <polacek at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Fri, 12 Aug 2016 12:14:11 +0200
- Subject: Re: RFC: A few more fallthrus
- Authentication-results: sourceware.org; auth=none
- References: <20160811144930.GV7007@redhat.com> <alpine.LSU.2.11.1608120919110.26629@t29.fhfr.qr>
On Fri, Aug 12, 2016 at 09:20:36AM +0200, Richard Biener wrote:
> > --- gcc/gcc/tree-complex.c
> > +++ gcc/gcc/tree-complex.c
> > @@ -1336,6 +1336,8 @@ expand_complex_division (gimple_stmt_iterator *gsi, tree inner_type,
> > rr = gimplify_build2 (gsi, code, inner_type, ai, bi);
> > ri = gimplify_build2 (gsi, code, inner_type, ar, bi);
> > ri = gimplify_build1 (gsi, NEGATE_EXPR, inner_type, ri);
> > + /* XXX Really fallthru? */
> > + /* FALLTHRU */
> >
>
>
> Nope, looks like a bug to me.
Thanks, thus:
Bootstrapped/regtested on x86_64-linux, applying to trunk.
2016-08-12 Marek Polacek <polacek@redhat.com>
PR c/7652
* tree-complex.c (expand_complex_division): Add missing break.
diff --git gcc/tree-complex.c gcc/tree-complex.c
index d7baf22..7668520 100644
--- gcc/tree-complex.c
+++ gcc/tree-complex.c
@@ -1336,6 +1336,7 @@ expand_complex_division (gimple_stmt_iterator *gsi, tree inner_type,
rr = gimplify_build2 (gsi, code, inner_type, ai, bi);
ri = gimplify_build2 (gsi, code, inner_type, ar, bi);
ri = gimplify_build1 (gsi, NEGATE_EXPR, inner_type, ri);
+ break;
case PAIR (ONLY_REAL, VARYING):
case PAIR (ONLY_IMAG, VARYING):
Marek