This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH], PR 72853, Fix Power9 issue with scalar double Altivec d-form instructions
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Tue, 9 Aug 2016 23:13:32 -0500
- Subject: Re: [PATCH], PR 72853, Fix Power9 issue with scalar double Altivec d-form instructions
- Authentication-results: sourceware.org; auth=none
- References: <20160810035326.GA27533@ibm-tiger.the-meissners.org>
On Tue, Aug 09, 2016 at 11:53:26PM -0400, Michael Meissner wrote:
> Index: gcc/config/rs6000/rs6000.c
> ===================================================================
> --- gcc/config/rs6000/rs6000.c (revision 239301)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -7739,6 +7739,9 @@ mem_operand_ds_form (rtx op, machine_mod
> int extra;
> rtx addr = XEXP (op, 0);
>
> + if (!MEM_P (op) || !offsettable_address_p (false, mode, addr))
> + return false;
Either the MEM_P test is superfluous, or it should come before the
XEXP above? Maybe the MEM_P part should be an assert?
Okay with that fixed (for trunk and 6). Thanks,
Segher