Re: libgo patch committed: Change build procedure to use build tags

["Lynn A. Boger" <laboger at linux dot vnet dot ibm dot com>]

libgo test results in gcc-testresults for ppc64le & ppc64 are back to 
what they were before the change.

Thanks.

On 08/08/2016 03:34 PM, Ian Lance Taylor wrote:
> On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger
> <laboger@linux.vnet.ibm.com> wrote:
> > The libgo tests on ppc64le and ppc64 have all been failing in
> > gcc-testresults since this change went in and continues to fail after the
> > recent fixes for failures on other platforms.
> >
> > Built myself and got the same failures.  I set keep=true in gotest to save
> > the test dirs.  Just running a single package:
> >
> > make bufio/check
> > file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not
> > found
> > Keeping gotest9734
> > FAIL: bufio
> > Makefile:3645: recipe for target 'bufio/check' failed
> > make: *** [bufio/check] Error 1
> > boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ ls
> > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> > boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ file
> > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go: ASCII text
> I found the problem.  I always configure with a relative srcdir.  You
> are using an absolute srcdir.  The recent changes to use build tags
> changed the libgo Makefile so that when invoked with with an absolute
> srcdir it would pass absolute path names to the gotest script.  That
> never worked.  This patch makes it work, and should fix your problem.
> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu with a
> relative srcdir and an absolute srcdir.  Committed to mainline.
>
> Ian