This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add more Aarch64 NEON intrinsics


On Mon, Aug 01, 2016 at 12:12:03PM +0100, Tamar Christina wrote:
> Hi all,
> 
> This patch adds the following NEON intrinsics to the ARM Aarch64 GCC:
> 
> * vmaxnm_f64
> * vminnm_f64
> * vmax_f64
> * vmin_f64
> 
> Some refactoring was done as well to remove some superfluous UNSPECS
> and iterators that could be combined into one.
> 
> <fmaxmin><mode>3 was removed from aarch64-simd.md because after the
> combining of the unspec FMAXMIN with FMAXMIN_UNS the pattern
> immediately above it now generates the same cases.
> 
> Added new tests for these and ran regression tests on aarch64-none-elf.
> 
> Ok for trunk?

Hi Tamar,

Thanks for the patch. This is OK for trunk.

I've spotted that you don't yet have commit rights, so I've committed this
patch on your behalf as r238977.

> gcc/
> 2016-07-08  Tamar Christina  <tamar.christina@arm.com>
> 
>     * config/aarch64/aarch64-simd-builtins.def

One note on your ChangeLog, though I'm guessing this was your mail
client/server, but these lines should be indented by a tab rather than 4
spaces. I fixed that up when I applied the patch.

>     (__builtin_aarch64_fmindf): Change BUILTIN_VDQF to BUILTIN_VDQF_DF.
>     (__builtin_aarch64_fmaxdf): Likewise.
>     (__builtin_aarch64_smin_nandf): Likewise.
>     (__builtin_aarch64_smax_nandf): Likewise.
>     * config/aarch64/aarch64-simd.md (<fmaxmin><mode>3): Remove.
>     * config/aarch64/aarch64.md (<fmaxmin><mode>3): Rename to...
>     (<fmaxmin><mode>3): ...this.
>     * config/aarch64/arm_neon.h (vmaxnm_f64): New.
>     (vminnm_f64): Likewise.
>     (vmin_f64): Likewise.
>     (vmax_f64): Likewise.
>     * config/aarch64/iterators.md (FMAXMIN): Merge with...
>     (FMAXMIN_UNS): ...this.
>     (fmaxmin): Merged with
>     (fmaxmin_op): ...this...
>     (maxmin_uns_op): ...in to this.
> 
> gcc/testsuite/
> 2016-07-11  Tamar Christina  <tamar.christina@arm.com>
> 
>     * gcc.target/aarch64/vminmaxnm.c: New.
>     * gcc.target/aarch64/simd/vminmaxnm_1.c (main): Added
> float64x1_t tests.

Thanks,
James


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]