This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, 2 of 4], Enhance PowerPC vec_extract support for power8/power9 machines
On Thu, Jul 28, 2016 at 03:44:25PM -0400, Michael Meissner wrote:
> > This isn't in the changelog.
>
> Yes it is.
I need new glasses.
> > > +/* Macro to say whether we can optimize vector extracts. */
> > > +#define VEC_EXTRACT_OPTIMIZE_P (TARGET_DIRECT_MOVE \
> > > + && TARGET_POWERPC64 \
> > > + && TARGET_UPPER_REGS_DI)
> >
> > I'm not a big fan of this name. "Optimize" will quickly become dated,
> > everyone will take the current new hot thing for granted, and then when
> > you want to optimise even more (say, for ISA 6.0 or whatever) the name
> > is really out of place.
> >
> > But I don't know a much better name either.
>
> I changed it to TARGET_DIRECT_MOVE_64BIT, which hopefully is clearer of what
> exactly we need. In particular, the calculation of the bit shift is done in
> the GPR and direct move creates teh vector used by VSLO to do a byte shift.
That is a much better name, thanks!
Segher