This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, Richard Biener <rguenther at suse dot de>, Jakub Jelinek <jakub at redhat dot com>, murphyp at linux dot vnet dot ibm dot com
- Date: Tue, 26 Jul 2016 18:26:19 -0500
- Subject: Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128
- Authentication-results: sourceware.org; auth=none
- References: <20160726152338.GA7191@ibm-tiger.the-meissners.org> <20160726160532.GA12959@gate.crashing.org> <20160726200901.GA655@ibm-tiger.the-meissners.org>
On Tue, Jul 26, 2016 at 04:09:01PM -0400, Michael Meissner wrote:
> > Could you test all five functions please? Use multiple testcases, maybe.
>
> I decided to write an executable test rather than do more assembly tests. The
> patch to rs6000.c is unchanged, and the test now tests all of the comparison
> operators and functions with various values including quiet NaNs and signalling
> NaNs. It passes on power7 big endian 64-bit, power7 big endian 32-bit, power8
> little endian 64-bit, and I ran it on the power9 simulator with hardware
> float128 support.
> --- gcc/testsuite/gcc.target/powerpc/float128-cmp.c (revision 0)
> +++ gcc/testsuite/gcc.target/powerpc/float128-cmp.c (revision 0)
> @@ -0,0 +1,106 @@
> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
> +/* { dg-require-effective-target ppc_float128_sw } */
> +/* { dg-options "-mvsx -O2 -mfloat128" } */
dg-do compile? That's not testing much then, as an executable test!
Segher