This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Implement -Wswitch-fallthrough: libstdc++
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 11 Jul 2016 23:18:45 +0100
- Subject: Re: Implement -Wswitch-fallthrough: libstdc++
- Authentication-results: sourceware.org; auth=none
- References: <20160711194340.GI13963@redhat.com> <20160711195759.GZ13963@redhat.com>
On 11 July 2016 at 20:57, Marek Polacek wrote:
>
> 2016-07-11 Marek Polacek <polacek@redhat.com>
>
> PR c/7652
> * libsupc++/hash_bytes.cc: Use __builtin_fallthrough.
>
> diff --git gcc/libstdc++-v3/libsupc++/hash_bytes.cc gcc/libstdc++-v3/libsupc++/hash_bytes.cc
> index 2e5bbfa..818331f 100644
> --- gcc/libstdc++-v3/libsupc++/hash_bytes.cc
> +++ gcc/libstdc++-v3/libsupc++/hash_bytes.cc
> @@ -95,8 +95,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> {
> case 3:
> hash ^= static_cast<unsigned char>(buf[2]) << 16;
> + __builtin_fallthrough ();
> case 2:
> hash ^= static_cast<unsigned char>(buf[1]) << 8;
> + __builtin_fallthrough ();
> case 1:
> hash ^= static_cast<unsigned char>(buf[0]);
> hash *= m;
Nice to see this feature implemented!
The libstdc++ change is gladly approved with much rejoicing. Thanks.