This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch, fortran] Fix PR 71783


Hello world,

this patch fixes the regression by always allocating a charlen.

Why we still allocate a temporary even for obviously non-overlapping
cases like the test case remains to be investigated. I'll open a
separate PR for this.

Regression-tested. OK for all affected branches?

Regards

	Thomas

2016-07-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/71783
        * frontend-passes.c (create_var):  Always allocate a charlen
        for character variables.

2016-07-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/71783
        * gfortran.dg/dependency_46.f90:  New test.
Index: frontend-passes.c
===================================================================
--- frontend-passes.c	(Revision 237949)
+++ frontend-passes.c	(Arbeitskopie)
@@ -665,12 +665,10 @@ create_var (gfc_expr * e, const char *vname)
     {
       gfc_expr *length;
 
+      symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
       length = constant_string_length (e);
       if (length)
-	{
-	  symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
-	  symbol->ts.u.cl->length = length;
-	}
+	symbol->ts.u.cl->length = length;
       else
 	symbol->attr.allocatable = 1;
     }
! { dg-do compile }
! PR 71783 - this used to ICE due to a missing charlen for the temporary.
! Test case by Toon Moene.

SUBROUTINE prtdata(ilen)
  INTEGER :: ilen
  character(len=ilen), allocatable :: cline(:)
  allocate(cline(2))
  cline(1) = 'a'
  cline(2) = cline(1)
END SUBROUTINE prtdata

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]