This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks

From: Jeff Law <law at redhat dot com>
To: Bernd Schmidt <bschmidt at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Manish Goregaokar <manish at mozilla dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Pedro Alves <palves at redhat dot com>, Andrew Pinski <pinskia at gcc dot gnu dot org>
Date: Fri, 8 Jul 2016 12:36:35 -0600
Subject: Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
Authentication-results: sourceware.org; auth=none
References: <CAFOnWk=xveuB-LNHHz4rE9+8vZK5yNfRPCTt5DUQs4ALdPKdtQ@mail.gmail.com> <CAFiYyc19Ap2kf4aWd-8Ebd-MYc2X6bubUs0h=iWNLr-w03aMpQ@mail.gmail.com> <CAFOnWkkLueeUeqCY3r3b-RTpJFXvsGOfCDyU3qeAqTJBvnVkhA@mail.gmail.com> <CAFiYyc15Aq0rcxSbzkxWY8Fs2HK6-wadv248tRKiYVGkxSZa4Q@mail.gmail.com> <CAFOnWknFZbBdpPm9h6tKLv4hwmKDW=68zimqom-eTbR4Lu=v9Q@mail.gmail.com> <alpine.DEB.2.20.1606301529270.2819@laptop-mg.saclay.inria.fr> <CAFiYyc2+PB2kqZnhoS8_V7KzOwDNXtL6y9BD0hncfJ7mgpu9Xg@mail.gmail.com> <alpine.DEB.2.20.1606301704070.2819@laptop-mg.saclay.inria.fr> <CAFiYyc060zH9m5=it-B_xvKfLY5rsp_b=0QwCyZ7xBvpoJumHg@mail.gmail.com> <CAFOnWkmL2jnin9e=p_fpVfXxywwHVvpvGcWkSk7SWvKOD8q_Og@mail.gmail.com> <CAFiYyc0_o+3f4JDD10a-CF4PRUANU=kP9sbGkxeXk=t0yUEUFA@mail.gmail.com> <13a11a30-62b5-23de-6396-d9bd519565dd@redhat.com>

On 07/06/2016 11:22 AM, Bernd Schmidt wrote:

On 07/05/2016 12:41 PM, Richard Biener wrote:

On Fri, Jul 1, 2016 at 3:10 PM, Manish Goregaokar <manish@mozilla.com>
wrote:

Added a test:


Ok if this passed bootstrap/regtest.

+      return flag_delete_null_pointer_checks
+            && (tree_expr_nonzero_warnv_p (op0, strict_overflow_p)
+                || tree_expr_nonzero_warnv_p (op1, strict_overflow_p));
     case PLUS_EXPR:


But please fix the wrapping - multi-line expressions like this should be
enclosed in parentheses to make the editor deal with them correctly.

I believe this patch regresses several tests in constexpr-array-ptr10.C.

jeff

Follow-Ups:
- Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
  - From: Manish Goregaokar

References:
- Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
  - From: Richard Biener
- Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
  - From: Manish Goregaokar
- Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
  - From: Richard Biener
- Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks
  - From: Bernd Schmidt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]