This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM 4/7, ping1] Factor out MOVW/MOVT availability and desirability checks
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Date: Thu, 07 Jul 2016 09:59:53 +0100
- Subject: Re: [PATCH, ARM 4/7, ping1] Factor out MOVW/MOVT availability and desirability checks
- Authentication-results: sourceware.org; auth=none
- References: <003401d138a0$d3757c70$7a607550$@foss.arm.com> <4211853.CieZkaLpEh@e108577-lin> <573F05FA.7030701@foss.arm.com>
On Friday 20 May 2016 13:41:30 Kyrill Tkachov wrote:
> Hi Thomas,
>
> On 19/05/16 17:10, Thomas Preudhomme wrote:
> > On Wednesday 18 May 2016 11:47:47 Kyrill Tkachov wrote:
> >> Hi Thomas,
> >
> > Hi Kyrill,
> >
> > Please find below the updated patch and associated ChangeLog entry.
> >
> > *** gcc/ChangeLog ***
> >
> > 2016-05-18 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * config/arm/arm.h (TARGET_USE_MOVT): Check MOVT/MOVW
> > availability
> > with TARGET_HAVE_MOVT.
> > (TARGET_HAVE_MOVT): Define.
> > * config/arm/arm.c (const_ok_for_op): Check MOVT/MOVW
> > availability with TARGET_HAVE_MOVT.
> > * config/arm/arm.md (arm_movt): Use TARGET_HAVE_MOVT to check
> > movt
> > availability.
> > (addsi splitter): Use TARGET_THUMB && TARGET_HAVE_MOVT rather
> > than
> > TARGET_THUMB2.
> > (symbol_refs movsi splitter): Remove TARGET_32BIT check.
> > (arm_movtas_ze): Use TARGET_HAVE_MOVT to check movt availability.
> > * config/arm/constraints.md (define_constraint "j"): Use
> > TARGET_HAVE_MOVT to check movt availability.
>
> Please use capitalised MOVW/MOVT consistently in the ChangeLog.
> Ok with a fixed ChangeLog.
Committed with the following ChangeLog entry:
2016-05-18 Thomas Preud'homme <thomas.preudhomme@arm.com>
* config/arm/arm.h (TARGET_USE_MOVT): Check MOVT/MOVW availability
with TARGET_HAVE_MOVT.
(TARGET_HAVE_MOVT): Define.
* config/arm/arm.c (const_ok_for_op): Check MOVT/MOVW
availability with TARGET_HAVE_MOVT.
* config/arm/arm.md (arm_movt): Use TARGET_HAVE_MOVT to check MOVT
availability.
(addsi splitter): Use TARGET_THUMB && TARGET_HAVE_MOVT rather than
TARGET_THUMB2.
(symbol_refs movsi splitter): Remove TARGET_32BIT check.
(arm_movtas_ze): Use TARGET_HAVE_MOVT to check MOVT availability.
* config/arm/constraints.md (define_constraint "j"): Use
TARGET_HAVE_MOVT to check MOVT availability.
Thanks.
Best regards,
Thomas