This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, rs6000] Fix PR target 71656, reload ICE when -mcpu=power9 -mpower9-dform-vector

From: Peter Bergner <bergner at vnet dot ibm dot com>
To: Segher Boessenkool <segher at kernel dot crashing dot org>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>
Date: Fri, 1 Jul 2016 12:59:18 -0500
Subject: Re: [PATCH, rs6000] Fix PR target 71656, reload ICE when -mcpu=power9 -mpower9-dform-vector
Authentication-results: sourceware.org; auth=none
References: <4c74251f-074e-4212-20e5-5f953ba2f795 at vnet dot ibm dot com> <20160627202102 dot GB23880 at gate dot crashing dot org> <f430a4c8-e288-d790-0caa-f532dfbfc0c1 at vnet dot ibm dot com>

On 6/27/16 8:30 PM, Peter Bergner wrote:

On 6/27/16 3:21 PM, Segher Boessenkool wrote:

On Sat, Jun 25, 2016 at 07:14:01PM -0500, Peter Bergner wrote:
Okay for trunk, okay for 6 later.  One comment:

+  if (VECTOR_MODE_P (mode)
+      && !mode_supports_vsx_dform_quad (mode))
+    return false;

   if (GET_CODE (addr) != PLUS)
     return false;

   op0 = XEXP (addr, 0);
-  if (!base_reg_operand (op0, Pmode))
+  if (!REG_P (op0)
+      || !INT_REG_OK_FOR_BASE_P (op0, strict))
     return false;


Just put these short conditionals on one line each?  It looks silly ;-)


Ok, committed to trunk with that change.  Thanks!


...and now committed to the FSF 6 branch.  Thanks.

Peter

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]