This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ix86_fp_cmp_code_to_pcmp_immediate (PR target/71559)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 20 Jun 2016 21:13:17 +0200
- Subject: Re: [PATCH] Fix ix86_fp_cmp_code_to_pcmp_immediate (PR target/71559)
- Authentication-results: sourceware.org; auth=none
- References: <20160620183159 dot GG7387 at tucnak dot redhat dot com> <CAFULd4bmD31XxG2owfEjmGNpoY-0rS_cQgT6XXvrZ0sqJ8nLAg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Jun 20, 2016 at 09:04:26PM +0200, Uros Bizjak wrote:
> OK for mainline and release branches after a week or so without
> problems in mainline.
Ok, thanks.
> (I tried to review usage of all those bits, LGTM, but mistakes can happen...)
I really hope the testcase should double check all that,
ix86_fp_cmp_code_to_pcmp_immediate is run with it on all the listed codes
except LTGT, and the expected results were written independently from the
tables and are also checked with SSE2 and AVX implementations.
When I've limited the testcase to the functions with only
EQ/NE/GT/LE/GE/LT, the testcase doesn't ICE, but aborted under the AVX512F
emulator.
Jakub