This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]Fix scan-tree-dump-times syntax errors in gcc.dg/tree-ssa/attr-hotcold-2.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Renlin Li <renlin dot li at foss dot arm dot com>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 20 Jun 2016 16:11:40 +0200
- Subject: Re: [PATCH]Fix scan-tree-dump-times syntax errors in gcc.dg/tree-ssa/attr-hotcold-2.c
- Authentication-results: sourceware.org; auth=none
- References: <20160607192704 dot GB22955 at kam dot mff dot cuni dot cz> <575EE0CA dot 3080109 at foss dot arm dot com> <5767F898 dot 2060006 at foss dot arm dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Jun 20, 2016 at 03:07:20PM +0100, Renlin Li wrote:
> Okay to commit?
>
> Regards,
> Renlin
>
> gcc/testsuite/ChangeLog:
>
> 2016-06-20 Renlin Li <renlin.li@arm.com>
>
> * gcc.dg/tree-ssa/attr-hotcold-2.c: Fix syntax errors.
This is obvious. Please check it in. Though, it also shows that
it couldn't have been properly tested.
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/attr-hotcold-2.c b/gcc/testsuite/gcc.dg/tree-ssa/attr-hotcold-2.c
> index 6623d9e..e2e8143 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/attr-hotcold-2.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/attr-hotcold-2.c
> @@ -18,8 +18,8 @@ void f(int x, int y)
> return;
> }
>
> -/* { dg-final { scan-tree-dump-times 1 "hot label heuristics" 1 "profile_estimate" } } */
> -/* { dg-final { scan-tree-dump-times 1 "cold label heuristics" 1 "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "hot label heuristics" 1 "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "cold label heuristics" 1 "profile_estimate" } } */
> /* { dg-final { scan-tree-dump-times "block 4, loop depth 0, count 0, freq \[1-4\]\[^0-9\]" 1 "profile_estimate" } } */
>
> /* Note: we're attempting to match some number > 6000, i.e. > 60%.
Jakub