This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM arm_neon.h] s/__FAST_MATH/__FAST_MATH__/g
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Kyrylo Tkachov <kyrylo dot tkachov at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>
- Date: Fri, 17 Jun 2016 09:25:57 +0100
- Subject: Re: [Patch ARM arm_neon.h] s/__FAST_MATH/__FAST_MATH__/g
- Authentication-results: sourceware.org; auth=none
- References: <1466097500-35271-1-git-send-email-james dot greenhalgh at arm dot com>
On Thu, Jun 16, 2016 at 6:18 PM, James Greenhalgh
<james.greenhalgh@arm.com> wrote:
>
> Hi,
>
> As subject, config/arm/arm_neon.h currently uses __FAST_MATH, but:
>
> $ gcc -E -dM - -ffast-math < /dev/null | grep FAST_MATH
> #define __FAST_MATH__ 1
>
> It should be spelled as __FAST_MATH__.
>
> I've made that change, and confirmed that it causes the preprocessor to
> do what was intended for these intrinsics under -ffast-math.
>
> Currently bootstrapped on arm-none-linux-gnueabihf with no issues.
Ok, thanks for finding this - I'm not sure how that got messed up and
given its so far back I don't have any records left.
>
> This could also be backported to release branches. I think Ramana's patch
> went in for GCC 5.0, so backports to gcc_5_branch and gcc_6_branch would
> be feasible.
>
It's not a regression fix , so lets just keep this on trunk.
Ramana
> Thanks,
> James
>
> ---
> 2016-06-16 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/arm/arm_neon.h (vadd_f32): replace __FAST_MATH with
> __FAST_MATH__.
> (vaddq_f32): Likewise.
> (vmul_f32): Likewise.
> (vmulq_f32): Likewise.
> (vsub_f32): Likewise.
> (vsubq_f32): Likewise.
>