This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ARM arm_neon.h] s/__FAST_MATH/__FAST_MATH__/g


On Thu, Jun 16, 2016 at 6:18 PM, James Greenhalgh
<james.greenhalgh@arm.com> wrote:
>
> Hi,
>
> As subject, config/arm/arm_neon.h currently uses __FAST_MATH, but:
>
>   $ gcc -E -dM - -ffast-math < /dev/null | grep FAST_MATH
>   #define __FAST_MATH__ 1
>
> It should be spelled as __FAST_MATH__.
>
> I've made that change, and confirmed that it causes the preprocessor to
> do what was intended for these intrinsics under -ffast-math.
>
> Currently bootstrapped on arm-none-linux-gnueabihf with no issues.

Ok, thanks for finding this - I'm not sure how that got messed up and
given its so far back I don't have any records left.

>
> This could also be backported to release branches. I think Ramana's patch
> went in for GCC 5.0, so backports to gcc_5_branch and gcc_6_branch would
> be feasible.
>

It's not a regression fix , so lets just keep this on trunk.

Ramana

> Thanks,
> James
>
> ---
> 2016-06-16  James Greenhalgh  <james.greenhalgh@arm.com>
>
>         * config/arm/arm_neon.h (vadd_f32): replace __FAST_MATH with
>         __FAST_MATH__.
>         (vaddq_f32): Likewise.
>         (vmul_f32): Likewise.
>         (vmulq_f32): Likewise.
>         (vsub_f32): Likewise.
>         (vsubq_f32): Likewise.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]