This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] Fix gcc.target/arm/builtin-bswap16-1.c
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Mon, 13 Jun 2016 09:42:57 +0200
- Subject: Re: [PATCH][ARM] Fix gcc.target/arm/builtin-bswap16-1.c
- Authentication-results: sourceware.org; auth=none
- References: <57514013 dot 3010608 at foss dot arm dot com> <575A8830 dot 4090208 at foss dot arm dot com>
On 10 June 2016 at 11:28, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
> Ping.
> https://gcc.gnu.org/ml/gcc-patches/2016-06/msg00249.html
>
I tested this patch in my usual matrix, and it's OK for me.
Christophe
> Thanks,
> Kyrill
>
>
> On 03/06/16 09:30, Kyrill Tkachov wrote:
>>
>> Hi all,
>>
>> The test gcc.target/arm/builtin-bswap16-1.c refuses to compile when
>> testing a toolchain configured with
>> --with-mode=thumb --with-float=hard and an architecture that supports
>> Thumb2.
>> This is because the test explicitly sets the -march option to armv6 and we
>> get an error complaining
>> about Thumb1 used with the hard-float ABI.
>>
>> The proposed solution in this patch is to bump the architecture to armv6t2
>> so that it uses Thumb2 when
>> -mthumb is used.
>>
>> But we don't want to lose Thumb1 test coverage. So this patch moves the
>> actual C code into a separate
>> .x file and includes it in two different tests, each testing Thumb1 or
>> Thumb2.
>>
>> The new test passes and builtin-bswap16-1.c also now passes rather than
>> complaining about the float ABI.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Kyrill
>>
>> 2016-06-03 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * gcc.target/arm/builtin-bswap16-1.c: Add -mfloat-abi=soft
>> and -mthumb to dg-options. Include builtin-bswap16.x.
>> * gcc.target/arm/builtin-bswap16: New file.
>> * gcc.target/arm/builtin-bswap16-2.c: New test.
>
>