This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM/AArch64 09/11] Add missing vrnd{,a,m,n,p,x} tests.
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Wed, 8 Jun 2016 09:37:01 +0200
- Subject: Re: [Patch ARM/AArch64 09/11] Add missing vrnd{,a,m,n,p,x} tests.
- Authentication-results: sourceware.org; auth=none
- References: <20160607154025 dot GC6963 at e103625-lin dot cambridge dot arm dot com> <AM3PR08MB00886D803EBB28921F1C9E96835D0 at AM3PR08MB0088 dot eurprd08 dot prod dot outlook dot com>
On 7 June 2016 at 19:05, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> Hi,
>
>
> These new tests cause failures due to running on non-ARMv8 hardware - the
> target check should be arm_v8_neon_hw. Also they don't run on AArch64
> hardware as arm_v8_neon_ok/arm_v8_neon_hw isn't true.
This really makes sense.
I use QEMU to run the tests, and according to my logs, the tests are compiled
with -mfpu=neon-fp-armv8 -march=armv8-a
and QEMU --cpu cortex-a9 (on the validation configurations intended to
validate armv7-a).
So... it looks like QEMU failed to reject the invalid instructions?
I'm using QEMU-2.4.1.
> check_effective_target_arm_v8_neon_hw in testsuite/lib/target-supports.exp
> needs to be extended to allow running on AArch64 as well, as these tests
> pass when I remove the dg-require-effective-target line.
Probably, I didn't take AArch64 into account when added these.
AArch64 intrinsics tests completion is still to be done.
Christophe
>
> Wilco
>
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vrnd.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vrnd.c
> new file mode 100644
> index 0000000..5f492d4
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vrnd.c
> @@ -0,0 +1,16 @@
> +/* { dg-require-effective-target arm_v8_neon_ok } */
>
> This should be arm_v8_neon_hw (the arm_v8_neon_ok can only be used for
> compilation).
>
> +/* { dg-add-options arm_v8_neon } */
>
> ________________________________