This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] C/C++ OpenACC routine directive, undeclared name error: try to help the user, once
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Nathan Sidwell <nathan at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 7 Jun 2016 09:02:56 +0200
- Subject: Re: [PING] C/C++ OpenACC routine directive, undeclared name error: try to help the user, once
- Authentication-results: sourceware.org; auth=none
- References: <877fejto7r dot fsf at hertz dot schwinge dot homeip dot net> <26f00f51-ba6f-afa0-958b-786cba73689b at acm dot org> <87shwyqlb6 dot fsf at kepler dot schwinge dot homeip dot net> <87twh5pkfz dot fsf at kepler dot schwinge dot homeip dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jun 07, 2016 at 08:44:16AM +0200, Thomas Schwinge wrote:
> On Tue, 31 May 2016 17:49:49 +0200, I wrote:
> > OK for trunk, as follows?
> >
> > commit 3289032bf7fd7e4a0cce37e7acd71e3330729d83
> > Author: Thomas Schwinge <thomas@codesourcery.com>
> > Date: Tue May 31 17:46:26 2016 +0200
> >
> > C/C++ OpenACC routine directive, undeclared name error: try to help the user, once
> >
> > gcc/c/
> > * c-parser.c (c_parser_oacc_routine): If running into an
> > undeclared name error, try to help the user, once.
> > gcc/cp/
> > * parser.c (cp_parser_oacc_routine): If running into an undeclared
> > name error, try to help the user, once.
> > gcc/testsuite/
> > * c-c++-common/goacc/routine-5.c: Update.
I don't like hinting user something that very often doesn't make any sense.
Wouldn't it be better to defer the inform call until we parse the next decl?
E.g. in the C++ FE arrange to have parser->oacc_routine set after the
directive, but with some new flag in there, and just throw it away silently
if it is not followed by function declaration, and emit the inform only if
the next declaration actually is the symbol mentioned in there?
In your testcase it is not followed by Baz declaration or definition, so
emitting the hint is just confusing.
Jakub