This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] PR52393 I/O: "READ format" statement with parenthesized default-char-expr
- From: Jerry DeLisle <jvdelisle at charter dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: FX <fxcoudert at gmail dot com>, gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 5 Jun 2016 15:28:17 -0700
- Subject: Re: [patch, fortran] PR52393 I/O: "READ format" statement with parenthesized default-char-expr
- Authentication-results: sourceware.org; auth=none
- References: <56bf245f-7f72-7f90-f9b6-c5aa0e5e5fd7 at charter dot net> <3F336BB9-A24D-4B1E-8E98-25DBC1246326 at gmail dot com> <510ebfd6-3e3c-c75b-e5d5-1328ebc28351 at charter dot net> <CAMe9rOqPsRa8DVphHKF5O7DcYWkSU-hgGNAVbkun7ztRbQ=tMw at mail dot gmail dot com>
On 06/03/2016 12:40 PM, H.J. Lu wrote:
> On Wed, Jun 1, 2016 at 9:28 AM, Jerry DeLisle <jvdelisle@charter.net> wrote:
>> On 06/01/2016 12:25 AM, FX wrote:
>>>> 2016-05-30 Jerry DeLisle <jvdelisle@gcc.gnu.org>
>>>>
>>>> PR fortran/52393
>>>> * io.c (match_io): For READ, try to match a default character
>>>> expression. If found, set the dt format expression to this,
>>>> otherwise go back and try control list.
>>>
>>> OK. Maybe you could add some ânegativeâ tests too? To be sure we still catch malformed parenthesized formats?
>>>
>>> FX
>>>
>>
>> Thanks for review! yes I will add some tests.
>>
>
> It caused:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71404
>
>
Patch committed.
Author: jvdelisle
Date: Sun Jun 5 19:49:59 2016
New Revision: 237108
URL: https://gcc.gnu.org/viewcvs?rev=237108&root=gcc&view=rev
Log:
2016-06-05 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/71404
* io.c (match_io): For READ, commit in pending symbols in the
current statement before trying to match an expression so that
if the match fails and we undo symbols we dont toss good symbols.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/io.c