This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, OpenACC] Make reduction arguments addressable

From: Chung-Lin Tang <cltang at codesourcery dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Thomas Schwinge <thomas at codesourcery dot com>, Cesar Philippidis <cesar_philippidis at mentor dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 3 Jun 2016 15:13:40 +0800
Subject: Re: [PATCH, OpenACC] Make reduction arguments addressable
Authentication-results: sourceware.org; auth=none
References: <fac841d6-320a-6de8-2bcd-07145151d0f3 at codesourcery dot com> <20160530165341 dot GS28550 at tucnak dot redhat dot com> <878tyqsn32 dot fsf at kepler dot schwinge dot homeip dot net> <3c5f38f7-ac02-6757-13bf-de48a1192048 at codesourcery dot com> <9b09bd96-cadc-538b-5341-6b2937ed78f5 at codesourcery dot com> <20160601133842 dot GQ28550 at tucnak dot redhat dot com> <fe1ec3d1-a2ca-89e1-2cd4-fa7734dae1d3 at codesourcery dot com> <20160602140022 dot GJ28550 at tucnak dot redhat dot com>

On 2016/6/2 10:00 PM, Jakub Jelinek wrote:
> Wouldn't it be better to pass either a bool openacc_async flag, or
> whole clauses, down to gfc_trans_omp_reduction_list and handle it there
> instead of walking the list after the fact?

You mean this style? (patch attached)
Tested again with no regressions.

Thanks,
Chung-Lin

        * trans-openmp.c (gfc_trans_omp_reduction_list): Add mark_addressable
        bool parameter, set reduction clause DECLs as addressable when true.
        (gfc_trans_omp_clauses): Pass clauses->async to
        gfc_trans_omp_reduction_list, add comment describing OpenACC situation.

Attachment: a.diff
Description: Text document

Follow-Ups:
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Jakub Jelinek
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Thomas Schwinge

References:
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Chung-Lin Tang
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Jakub Jelinek
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Chung-Lin Tang
- Re: [PATCH, OpenACC] Make reduction arguments addressable
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]