This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: More backwards/FSM jump thread refactoring and extension
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 24 May 2016 20:03:36 -0400
- Subject: Re: More backwards/FSM jump thread refactoring and extension
- Authentication-results: sourceware.org; auth=none
- References: <aae9f28b-bd4a-5a48-d75b-83d73f94a438 at redhat dot com>
On Tue, May 24, 2016 at 10:58:18AM -0600, Jeff Law wrote:
> --- a/gcc/tree-ssa-threadbackward.c
> +++ b/gcc/tree-ssa-threadbackward.c
> @@ -356,6 +356,44 @@ profitable_jump_thread_path (vec<basic_block, va_gc> *&path,
> return taken_edge;
> }
>
> +/* PATH is vector of blocks forming a jump threading path in reverse
> + order. TAKEN_EDGE is the edge taken from path[0].
> +
> + Convert that path into the form used by register_jump_thread and
> + register the path. */
> +
> +static void
> +convert_and_register_jump_thread_path (vec<basic_block, va_gc> *&path,
is there a reason that isn't vec<basic_block, va_gc> * instead of
vec<basic_block> *&? It seems like that's just useless indirection, and
allowing this function to be able to change more than it needs.
> + edge taken_edge)
> +{
> + vec<jump_thread_edge *> *jump_thread_path = new vec<jump_thread_edge *> ();
Its not new, but I'm always a little sad to see something that's only
sizeof(void *) big be malloced on its own.
Trev