This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct


On May 15, 2016, at 1:30 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> 
> Can we recommend that clang disable this warning by default instead?

No.  We want to ensure the class/struct tags match as there is no good reason to have them differ.

> Or use an option flag to disable the warning while compiling gcc?

Don't need the option to disable it, as once we fix gcc, it won't produce these warnings.  If clang produces warnings for constructs we do want to use, then we disable those warnings as uninteresting.  For example, if they warned for line widths more than 80, and we don't have a hard rule about 80, then we'd turn it off as overly pedantic for our source base, even though in most files, most of the time we were 80 or under.  If we had a hard and fast rule, no lines over 80, ever, then we'd not turn that warning off, rather, we would fixed the software to conform to that.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]