This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct
- From: Mike Stump <mikestump at comcast dot net>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: Gerald Pfeifer <gerald at pfeifer dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <rdsandiford at googlemail dot com>, Kenneth Zadeck <zadeck at naturalbridge dot com>
- Date: Tue, 17 May 2016 08:38:44 -0700
- Subject: Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 20 dot 1605152057040 dot 2881 at anthias dot pfeifer dot com> <CA+=Sn1nPC0Rno_OAGg32LYqQAeFy4BfKys_7yaKUdfEA+k+TWQ at mail dot gmail dot com>
On May 15, 2016, at 1:30 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>
> Can we recommend that clang disable this warning by default instead?
No. We want to ensure the class/struct tags match as there is no good reason to have them differ.
> Or use an option flag to disable the warning while compiling gcc?
Don't need the option to disable it, as once we fix gcc, it won't produce these warnings. If clang produces warnings for constructs we do want to use, then we disable those warnings as uninteresting. For example, if they warned for line widths more than 80, and we don't have a hard rule about 80, then we'd turn it off as overly pedantic for our source base, even though in most files, most of the time we were 80 or under. If we had a hard and fast rule, no lines over 80, ever, then we'd not turn that warning off, rather, we would fixed the software to conform to that.