This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [MIPS,committed] Update MIPS P5600 processor definition to avoid IMADD
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Maciej Rozycki <Maciej dot Rozycki at imgtec dot com>
- Cc: "'gcc-patches at gcc dot gnu dot org' (gcc-patches at gcc dot gnu dot org)" <gcc-patches at gcc dot gnu dot org>, "Moore, Catherine (Catherine_Moore at mentor dot com)" <Catherine_Moore at mentor dot com>
- Date: Mon, 16 May 2016 12:51:02 +0000
- Subject: RE: [MIPS,committed] Update MIPS P5600 processor definition to avoid IMADD
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B023537E3F8609 at hhmail02 dot hh dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1605050050440 dot 6794 at tp dot orcam dot me dot uk>
Maciej Rozycki <Maciej.Rozycki@imgtec.com> writes:
> On Wed, 4 May 2016, Matthew Fortune wrote:
>
> > diff --git a/gcc/config/mips/mips-cpus.def
> > b/gcc/config/mips/mips-cpus.def index 17034f2..5df9807 100644
> > --- a/gcc/config/mips/mips-cpus.def
> > +++ b/gcc/config/mips/mips-cpus.def
> > @@ -44,10 +44,7 @@ MIPS_CPU ("mips4", PROCESSOR_R10000, 4, 0)
> > isn't tuned to a specific processor. */ MIPS_CPU ("mips32",
> > PROCESSOR_4KC, 32, PTF_AVOID_BRANCHLIKELY) MIPS_CPU ("mips32r2",
> > PROCESSOR_74KF2_1, 33, PTF_AVOID_BRANCHLIKELY)
> > -/* mips32r3 is micromips hense why it uses the M4K processor.
> > - mips32r5 should use the p5600 processor, but there is no
> definition
> > - for this yet, so in the short term we will use the same processor
> entry
> > - as mips32r2. */
> > +/* mips32r3 is micromips hense why it uses the M4K processor. */
>
> Typo here -> s/hense/hence/ -- since you've reworked the comment and
> changed the line in the course anyway, you may have well taken the
> opportunity and fixed it.
I saw it but chose not to fix on the basis of one change leads to another.
> > @@ -150,7 +147,8 @@ MIPS_CPU ("1004kf1_1", PROCESSOR_24KF1_1, 33, 0)
> > MIPS_CPU ("interaptiv", PROCESSOR_24KF2_1, 33, 0)
> >
> > /* MIPS32 Release 5 processors. */
> > -MIPS_CPU ("p5600", PROCESSOR_P5600, 36, PTF_AVOID_BRANCHLIKELY)
> > +MIPS_CPU ("p5600", PROCESSOR_P5600, 36, PTF_AVOID_BRANCHLIKELY
> > + | PTF_AVOID_IMADD)
>
> Not:
>
> MIPS_CPU ("p5600", PROCESSOR_P5600, 36, (PTF_AVOID_BRANCHLIKELY
> | PTF_AVOID_IMADD))
Good spot, brackets added. I almost didn't split the line for fear
of breaking the awk parsing.
Thanks,
Matthew
diff --git a/gcc/config/mips/mips-cpus.def b/gcc/config/mips/mips-cpus.def
index 5df9807..b46c86f 100644
--- a/gcc/config/mips/mips-cpus.def
+++ b/gcc/config/mips/mips-cpus.def
@@ -147,8 +147,8 @@ MIPS_CPU ("1004kf1_1", PROCESSOR_24KF1_1, 33, 0)
MIPS_CPU ("interaptiv", PROCESSOR_24KF2_1, 33, 0)
/* MIPS32 Release 5 processors. */
-MIPS_CPU ("p5600", PROCESSOR_P5600, 36, PTF_AVOID_BRANCHLIKELY
- | PTF_AVOID_IMADD)
+MIPS_CPU ("p5600", PROCESSOR_P5600, 36, (PTF_AVOID_BRANCHLIKELY
+ | PTF_AVOID_IMADD))
MIPS_CPU ("m5100", PROCESSOR_M5100, 36, PTF_AVOID_BRANCHLIKELY)
MIPS_CPU ("m5101", PROCESSOR_M5100, 36, PTF_AVOID_BRANCHLIKELY)
--
2.2.1