This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM/AArch64 06/11] Add missing vtst_p8 and vtstq_p8 tests.
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Fri, 13 May 2016 15:47:48 +0100
- Subject: Re: [Patch ARM/AArch64 06/11] Add missing vtst_p8 and vtstq_p8 tests.
- Authentication-results: sourceware.org; auth=none
- Nodisclaimer: True
- References: <1462973041-7911-1-git-send-email-christophe dot lyon at linaro dot org> <1462973041-7911-7-git-send-email-christophe dot lyon at linaro dot org> <20160513143709 dot GB12266 at arm dot com> <CAKdteOZ5HgDUbzmPiDeU9XTqTGBctK-x6xcyVs7T8A-zrvQ0nQ at mail dot gmail dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
On Fri, May 13, 2016 at 04:41:33PM +0200, Christophe Lyon wrote:
> On 13 May 2016 at 16:37, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> > On Wed, May 11, 2016 at 03:23:56PM +0200, Christophe Lyon wrote:
> >> 2016-05-02 Christophe Lyon <christophe.lyon@linaro.org>
> >>
> >> * gcc.target/aarch64/advsimd-intrinsics/vtst.c: Add tests
> >> for vtst_p8 and vtstq_p8.
> >
> > And vtst_p16 and vtstq_p16 too please.
> >
> > vtst_s64
> > vtstq_s64
> > vtst_u64
> > vtstq_u64 are also missing (AArch64 only).
> >
> vtst_p16/vtstq_p16 are AArch64 only too, right?
Not in my copy of:
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref.pdf
I see it is missing from config/arm/arm_neon.h so that's a bug in the GCC
implementation. It should be easy to resolve, map it to the same place
as vtst_u16 and vtst_s16 - this is just a bit operation which takes no
semantics from the data-type.
Would you mind spinning the fix for that and committing it before this
patch?
> My introduction message was not clear enough: this series
> only attempts to fully cover AArch32 intrinsics.
Understood, sorry for the extra noise.
Thanks,
James