This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR71039
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 11 May 2016 11:56:08 +0200
- Subject: Re: [PATCH] Fix PR71039
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1605101505590 dot 18037 at t29 dot fhfr dot qr> <79AE9A35-B673-411B-92E6-355629509D28 at gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1605111136000 dot 18037 at t29 dot fhfr dot qr>
On May 11, 2016 11:36:11 AM GMT+02:00, Richard Biener <rguenther@suse.de> wrote:
>On Wed, 11 May 2016, Bernhard Reutner-Fischer wrote:
>
>> On May 10, 2016 3:07:12 PM GMT+02:00, Richard Biener
><rguenther@suse.de> wrote:
>> >
>> >The following fixes PR71039 - we were failing to verify we can
>> >insert the lhs on the predecessor edges.
>> >
>> >Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.
>>
>> >+ /* Verify if *idx is available at *DATA. */
>> >+
>> >+ static bool
>> >+ chk_uses (tree t, tree *idx, void *data)
>> >+ {
>> >+ basic_block dom = (basic_block) data;
>> >+ if (TREE_CODE (*idx) == SSA_NAME)
>> >+ return (SSA_NAME_IS_DEFAULT_DEF (*idx)
>> >+ || ! dominated_by_p (CDI_DOMINATORS,
>> >+ gimple_bb (SSA_NAME_DEF_STMT (*idx)), dom));
>> >+ return true;
>> >+ }
>>
>> Shouldn't this warn about unused t?
>
>I fixed that before committing.
Thanks, Sorry for the noise.