This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Better location info for "incomplete type" error msg (PR c/70756)
- From: Jason Merrill <jason at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 4 May 2016 11:52:39 -0400
- Subject: Re: [PATCH] Better location info for "incomplete type" error msg (PR c/70756)
- Authentication-results: sourceware.org; auth=none
- References: <20160428155908 dot GQ28445 at redhat dot com> <5723BE3D dot 4070706 at redhat dot com> <20160502164149 dot GE5348 at redhat dot com> <57278FA6 dot 90308 at redhat dot com> <20160503112707 dot GH5348 at redhat dot com> <57293CDB dot 6040204 at redhat dot com> <20160504130013 dot GJ5348 at redhat dot com>
On Wed, May 4, 2016 at 9:00 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Tue, May 03, 2016 at 08:05:47PM -0400, Jason Merrill wrote:
>> Looks good.
>>
>> But I don't see a C++ testcase; can the test go into c-c++-common?
>
> Sadly, no. As of now, the patch doesn't improve things for C++ (?). Seems
> we'd need to pass better locations down to pointer_int_sum / size_in_bytes.
> It cascades :(.
Sure. But can you fix that, too, while you're thinking about it?
Passing the location to cp_pointer_int_sum and pointer_diff seems
pretty simple.
Jason