This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ping][patch] update handling of 'acc parallel loop' reductions for PR70626
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar_philippidis at mentor dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 29 Apr 2016 09:08:12 +0200
- Subject: Re: [ping][patch] update handling of 'acc parallel loop' reductions for PR70626
- Authentication-results: sourceware.org; auth=none
- References: <57115D6F dot 4000207 at codesourcery dot com> <57229369 dot 2090900 at mentor dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Apr 28, 2016 at 03:49:13PM -0700, Cesar Philippidis wrote:
> 2016-04-15 Cesar Philippidis <cesar@codesourcery.com>
>
> gcc/c-family/
> PR middle-end/70626
> * c-common.h (c_oacc_split_loop_clauses): Add boolean argument.
> * c-omp.c (c_oacc_split_loop_clauses): Use it to duplicate
> reduction clauses in acc parallel loops.
>
> gcc/c/
> PR middle-end/70626
> * c-parser.c (c_parser_oacc_loop): Don't augment mask with
> OACC_LOOP_CLAUSE_MASK.
> (c_parser_oacc_kernels_parallel): Update call to
> c_oacc_split_loop_clauses.
>
> gcc/cp/
> PR middle-end/70626
> * parser.c (cp_parser_oacc_loop): Don't augment mask with
> OACC_LOOP_CLAUSE_MASK.
> (cp_parser_oacc_kernels_parallel): Update call to
> c_oacc_split_loop_clauses.
>
> gcc/fortran/
> PR middle-end/70626
> * trans-openmp.c (gfc_trans_oacc_combined_directive): Duplicate
> the reduction clause in both parallel and loop directives.
>
> gcc/testsuite/
> PR middle-end/70626
> * c-c++-common/goacc/combined-reduction.c: New test.
> * gfortran.dg/goacc/reduction-2.f95: Add check for kernels reductions.
>
> libgomp/
> PR middle-end/70626
> * testsuite/libgomp.oacc-c++/template-reduction.C: Adjust test.
> * testsuite/libgomp.oacc-c-c++-common/combined-reduction.c: New test.
> * testsuite/libgomp.oacc-fortran/combined-reduction.f90: New test.
LGTM.
Jakub