This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] asan: Don't check frame numbers in the testsuite
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 28 Apr 2016 18:03:38 +0200
- Subject: Re: [PATCH] asan: Don't check frame numbers in the testsuite
- Authentication-results: sourceware.org; auth=none
- References: <02e2f9bdf25fedda76bc21608dab76524c8fa208 dot 1461858415 dot git dot segher at kernel dot crashing dot org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Apr 28, 2016 at 03:57:38PM +0000, Segher Boessenkool wrote:
> On various PowerPC configurations, the top frame is often mentioned
> twice in the backtrace, making many asan tests fail. I see no particular
> reason the asan tests want to check the frame number, so this patch
> makes it check for " #. " instead of " #1 ", etc., in all of the
> c-c++-common/asan tests.
Wouldn't it be better to fix the backtrace stuff for PowerPC, so that
the top frame is not mentioned twice when it shouldn't?
I mean, if it annoys the tests (where IMHO it is still useful to test
the numbers, to avoid e.g. having some unrelated frames being printed first
or bugs like this to be caught), it will annoy users as well.
Jakub