This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Update gmp/mpfr/mpc in-tree versions
- From: Richard Biener <rguenther at suse dot de>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: Joseph Myers <joseph at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Marc Glisse <marc dot glisse at inria dot fr>; Jakub Jelinek <jakub at redhat dot com>; Jonathan Wakely" <jwakely at redhat dot com>
- Date: Thu, 28 Apr 2016 16:29:53 +0200 (CEST)
- Subject: Re: [PATCH] Update gmp/mpfr/mpc in-tree versions
- Authentication-results: sourceware.org; auth=none
- References: <AM4PR07MB1571E7BDED31B7C146A0BC4CE4630 at AM4PR07MB1571 dot eurprd07 dot prod dot outlook dot com> <alpine dot DEB dot 2 dot 20 dot 1604262007090 dot 2787 at digraph dot polyomino dot org dot uk> <HE1PR07MB15805C6A09E3DAC3380023BEE4640 at HE1PR07MB1580 dot eurprd07 dot prod dot outlook dot com> <alpine dot LSU dot 2 dot 11 dot 1604280903150 dot 13384 at t29 dot fhfr dot qr> <AM4PR07MB157126273516C6B5E78F4052E4650 at AM4PR07MB1571 dot eurprd07 dot prod dot outlook dot com> <alpine dot LSU dot 2 dot 11 dot 1604281432290 dot 13384 at t29 dot fhfr dot qr> <AM4PR07MB157123EEAF98313960EF95D9E4650 at AM4PR07MB1571 dot eurprd07 dot prod dot outlook dot com>
On Thu, 28 Apr 2016, Bernd Edlinger wrote:
> On 28.04.2016 14:35, Richard Biener wrote:
> > On Thu, 28 Apr 2016, Bernd Edlinger wrote:
> >
> >> Hi,
> >>
> >> here is the first part of the patch that addresses only the in-tree
> >> builds. I tried different combinations of the documented supported
> >> in-tree versions, and all combinations seem to work.
> >> Then I changed the download_prerequisites batch to pick each pre-
> >> requisite's minimum version (that part is not tested, because I have
> >> no way to update the gcc.gnu.org ftp server).
> >>
> >> Various boot-straps for x86_64-linux-gnu and armv7-linux-gnueabihf
> >> were successful.
> >>
> >> Is it OK for trunk?
> >
> > Please do not document that in-tree versions greater than XXX are
> > supported, instead just point at download_prerequesites.
> >
>
> OK, done.
>
> > Why do you not update to latest mpc (there is 1.0.3) and mpfr but leave
> > bugfixes for mpfr on the plate (there is 3.1.4).
> >
>
> There's not really a good reason for that choice.
>
> I just started with the latest version, and later moved to older
> versions, because I did not want to restrict the supported versions
> more than absolutely necessary, not even in-tree.
>
> Are there any bug-fixes that we could depend upon?
>
> > Does it make sense to wait for a new GMP release that allows to get
> > rid of -DNO_ASM?
> >
>
> I was _very_ surprised that gmp-6.0.0 did at first work in-tree but
> enabled invalid assembly code, in gmp-6.0.0/mpn/generic/div_qr_1n_pi1.c
> when __arm__ or __sparc__ or __s390x__ is defined together with NO_ASM.
>
> All in all GMP contains really much assembler code that we don't need
> at all, my impression is that it is nearly impossible to test GMP
> on every possible target, although it is all about mathematics.
> So at least some choice would be good for us.
>
> In that sense, I would not like to restrict the supported GMP versions
> to just one version, that is not even released at this time.
Another option would be to try if mini-gmp is enough for our
(in-tree) use and what the performance impact would be if we'd
use that (in-tree).
> > I will upload mpfr 3.1.4 and mpc 1.0.3.
> >
>
> Good. I updated the download_prerequsites to mpfr-3.1.4 and mpc-1.0.3
> again, but left gmp-6.1.0 at the moment.
Thanks,
Richard.