This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C, C++: New warning for memset without multiply by elt size

From: Jason Merrill <jason at redhat dot com>
To: Bernd Schmidt <bschmidt at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Mon, 25 Apr 2016 13:55:43 -0400
Subject: Re: C, C++: New warning for memset without multiply by elt size
Authentication-results: sourceware.org; auth=none
References: <571A2776 dot 6060502 at t-online dot de> <CADzB+2nWcp_eVTGTp9KdvzjdsmxNoLBF_vJOzz=RuB37AR5NdQ at mail dot gmail dot com> <571DDE39 dot 7060200 at redhat dot com>

On 04/25/2016 05:07 AM, Bernd Schmidt wrote:

+		if (TREE_CODE (arg2) == CONST_DECL)
+		  arg2 = DECL_INITIAL (arg2);
+		int literal_mask = ((!!integer_zerop (arg1) << 1)
+				    | (!!integer_zerop (arg2) << 2));

Are you deliberately treating an enumerator as a literal 0? I'd thinkwe should set literal_mask before stripping CONST_DECL. OK with thatchange.


Jason

Follow-Ups:
- Re: C, C++: New warning for memset without multiply by elt size
  - From: Bernd Schmidt

References:
- C, C++: New warning for memset without multiply by elt size
  - From: Bernd Schmidt
- Re: C, C++: New warning for memset without multiply by elt size
  - From: Jason Merrill
- Re: C, C++: New warning for memset without multiply by elt size
  - From: Bernd Schmidt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]