This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Add support for vector element-reversal built-ins
- From: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: gcc-patches at gcc dot gnu dot org, dje dot gcc at gmail dot com
- Date: Sun, 24 Apr 2016 17:33:09 -0500
- Subject: Re: [PATCH, rs6000] Add support for vector element-reversal built-ins
- Authentication-results: sourceware.org; auth=none
- References: <1461524807 dot 29088 dot 12 dot camel at oc8801110288 dot ibm dot com> <20160424205221 dot GA2935 at gate dot crashing dot org>
On Sun, 2016-04-24 at 15:52 -0500, Segher Boessenkool wrote:
> On Sun, Apr 24, 2016 at 02:06:47PM -0500, Bill Schmidt wrote:
> > ISA 3.0 adds the lvxh8x, lvxb16x, stvxh8x, and stvxb16x instructions,
>
> lxvh8x etc. It looks like you only swapped things in this message,
> not in the actual patch :-)
D'oh! Yes, I make that typo all the time...
>
> > (While working on this patch, I happened to notice that the existing
> > entries in rs6000-builtin.def for STXVD2X_<MODE> and STXVW4X_<MODE> are
> > mapped to stxsdx instead of stxvd2x/stxvw4x. I took the opportunity to
> > correct that as an obvious bug.)
>
> Does that part need backporting?
Yes, we should do that.
>
> Should the new builtins be documented?
Bah, I knew I had forgotten something. Yes, they should. I'll put
together a follow-on patch to update the documentation.
Thanks!
Bill
>
> Looks fine otherwise.
>
>
> Segher
>