This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr.
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, uweigand at de dot ibm dot com
- Date: Tue, 19 Apr 2016 18:13:50 +0200
- Subject: Re: [PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr.
- Authentication-results: sourceware.org; auth=none
- References: <1461056554-18150-1-git-send-email-krebbel at linux dot vnet dot ibm dot com> <20160419105400 dot GP2920 at laptop dot zalov dot cz>
On 04/19/2016 12:54 PM, Jakub Jelinek wrote:
> Can you please:
> rtx fpr = gen_rtx_REG (DImode, cfun_gpr_save_slot (i));
> if (i == STACK_POINTER_REGNUM)
> insn = emit_insn (gen_stack_restore_from_fpr (fpr));
> else
> insn = emit_move_insn (gen_rtx_REG (DImode, i), fpr);
> That way IMHO it is more nicely formatted, you avoid the ugly (
> at the end of line, it uses fewer lines anyway and additionally
> you can make it clear what the gen_rtx_REG (DImode, cfun_gpr_save_slot (i))
> means by giving it a name. Of course, choose whatever other var
> name you prefer to describe what it is.
Right, that's better. I'll change the patch and commit it tomorrow. Thanks!
-Andreas-