This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove UNSPEC_LOADU and UNSPEC_STOREU
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Apr 2016 16:53:28 +0300
- Subject: Re: [PATCH] Remove UNSPEC_LOADU and UNSPEC_STOREU
- Authentication-results: sourceware.org; auth=none
- References: <20160110223205 dot GB25853 at gmail dot com> <CAFULd4ZMowXBpkLGrUiAT5YpKkpCeKSLgi7=ofr7a-WFvjdDMw at mail dot gmail dot com> <CAMe9rOrb4f_nqLwjFensh5R+1T90dmma_3TjJdeLmVcTBP1BGA at mail dot gmail dot com> <CAFULd4asb8owpYHJZKOmZgMKVpCOCB_kNctOdy-QOmDd9amzeg at mail dot gmail dot com>
Hi,
On 18 Apr 21:13, Uros Bizjak wrote:
> On Mon, Apr 18, 2016 at 8:40 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Sun, Jan 10, 2016 at 11:45 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> >> On Sun, Jan 10, 2016 at 11:32 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> >>> Since *mov<mode>_internal and <avx512>_(load|store)<mode>_mask patterns
> >>> can handle unaligned load and store, we can remove UNSPEC_LOADU and
> >>> UNSPEC_STOREU. We use function prototypes with pointer to scalar for
> >>> unaligned load/store builtin functions so that memory passed to
> >>> *mov<mode>_internal is unaligned.
> >>>
> >>> Tested on x86-64. Is this OK for trunk in stage 3?
> >>
> >> This patch is not appropriate for stage 3.
> >>
> >> Uros.
> >>
> >>> H.J.
> >>> ----
> >
> >
> > Here is the updated patch for GCC 7. Tested on x86-64. OK for
> > trrunk?
>
> IIRC from previous discussion, are we sure we won't propagate
> unaligned memory into SSE arithmetic insns?
>
> Otherwise, the patch is OK, but please wait for Kirill for AVX512 approval.
I am ok with it.
>
> Thanks,
> Uros.
--
Thanks, K