This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix an openacc reference-type reduction bug in PR70643
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 14 Apr 2016 07:31:14 +0200
- Subject: Re: [patch] fix an openacc reference-type reduction bug in PR70643
- Authentication-results: sourceware.org; auth=none
- References: <570ECE96 dot 2000106 at codesourcery dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 13, 2016 at 03:56:22PM -0700, Cesar Philippidis wrote:
> Thomas noticed that one of the openacc fortran tests involving
> reductions inside fortran modules in gomp-4_0-branch had regressed after
> I backported the recent reduction changes I made to trunk. That failure
> occurred because lower_oacc_reductions wasn't considering that reduction
> initializers can be non-integral constants. This patch fixes that
> problem and adds a new runtime test case.
>
> Is this patch ok for trunk? I tested it on x86_64-linux.
>
> Cesar
> 2016-04-13 Cesar Philippidis <cesar@codesourcery.com>
>
> gcc/
> * omp-low.c (lower_oacc_reductions): Check for TREE_CONSTANT
> when building a mem ref for the incoming reduction variable.
>
> libgomp/
> * testsuite/libgomp.oacc-fortran/pr70643.f90: New test.
Ok.
Jakub