This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Disable guality tests for powerpc*-linux*
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Tue, 29 Mar 2016 12:06:53 -0700
- Subject: Re: [PATCH] Disable guality tests for powerpc*-linux*
- Authentication-results: sourceware.org; auth=none
- References: <1459211926 dot 12955 dot 37 dot camel at oc8801110288 dot ibm dot com> <CAGWvnyki5Ezg6whPLQV-ik47oLErmpVKYgX4ePX7W_HuNvxH-g at mail dot gmail dot com> <90ABF9B7-E079-43C7-88AF-2E58E9E3CA30 at comcast dot net> <20160329184245 dot GV3017 at tucnak dot redhat dot com>
On Tue, Mar 29, 2016 at 11:42 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Mar 29, 2016 at 11:34:17AM -0700, Mike Stump wrote:
>> On Mar 29, 2016, at 7:45 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
>> > We have no plans to make code generation a slave to the testsuite.
>> > The testsuite is a tool, successful results from the testsuite is not
>> > a goal unto itself.
>> >
>> > This patch is okay.
>>
>> We look forward to the day when someone can find the time and energy and
>> desire to make subsets of this work better and reenable those as they
>> bring them back online. I view it as I do for turning off C++ testing on
>> a PIC target, if no one wants to make it work nicely, then it is better to
>> just turn it off. Anyone with the desire to make these tests work nicely
>> will step forward and donate as they are able to. If someone would like
>> that work done, you can edit up a TODO or projects file to describe the
>> work youâd like done, and try and find someone that would like to do the
>> work, or, just do the work yourself. If someone has the free time, and
>> wants to tackle this project, merely step forward and let others know.
>> This is how we make progress.
>
> The problem with the disabling is not in those tests that don't pass right
> now on whatever target you are testing on, but with any regressions in tests
> that pass right now but will not pass in half a year or year because of GCC
> changes; if the tests are disabled, nobody will notice that, one can't look
> at gcc-regressions or elsewhere to find out quickly where it regressed, etc.
>
> Jakub
One issue with gcc.dg/guality/guality.exp is when there is an ICE
regression during guality init, all sudden there is no failure in guality
tests:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68545
Next time, when ICE is fixed, a bunch of guality failures show up.
--
H.J.