This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Disable guality tests for powerpc*-linux*


On Mon, Mar 28, 2016 at 07:38:46PM -0500, Bill Schmidt wrote:
> For a long time we've had hundreds of failing guality tests.  These
> failures don't seem to have any correlation with gdb functionality for
> POWER, which is working fine.  At this point the value of these tests to
> us seems questionable.  Fixing these is such low priority that it is
> unlikely we will ever get around to it.  In the meanwhile, the failures
> simply clutter up our regression test reports.  Thus I'd like to disable
> them, and that's what this test does.
> 
> Verified to remove hundreds of failure messages on
> powerpc64le-unknown-linux-gnu. :)  Is this ok for trunk?

This is IMNSHO very wrong, you then lose tracking of regressions in the
debug info quality.  It is true that the debug info quality is already
pretty bad  on powerpc*, it would be really very much desirable if
anyone had time to analyze some of them and improve stuff,
but we at least shouldn't regress.  Guality testsuite has various FAILs
and/or XFAILs on lots of architectures, the problem is that the testing
matrix is simply too large to have them in the testcases
- it depends on the target, various ISA settings on the target, on the
optimization level (most of the guality tests are torture tested through
-O0 up to -O3 with extra flags), and in some cases also on the version of
the used GDB.

For guality, the most effective test for regressions is simply always
running contrib/test_summary after all your bootstraps and then just
diffing up that against the same from earlier bootstrap.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]