This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2][GCC][ARM] Fix testcases after introduction of Cortex-R8



On 09/03/16 16:57, Andre Vieira (lists) wrote:
On 08/03/16 14:56, Kyrill Tkachov wrote:
Hi Andre,

On 08/03/16 11:05, Andre Vieira (lists) wrote:
On 03/03/16 11:28, Kyrill Tkachov wrote:
Hi Andre,

On 02/03/16 12:21, Andre Vieira (lists) wrote:
Hi,

Tests used to check for "r8" which will not work because cortex-r8
string is now included in the assembly. Fixed by checking for
"[^\-]r8".

Is this Ok?

Cheers,
Andre

gcc/testsuite/ChangeLog:

2016-03-02  Andre Vieira  <andre.simoesdiasvieira@arm.com>

        * gcc.target/arm/pr45701-1.c: Change assembler scan to not
        trigger for cortex-r8, when scanning for register r8.
        * gcc.target/arm/pr45701-2.c: Likewise.
Ok.
Thanks,
Kyrill

Thomas commited on my behalf at revision r234040.

Had to rebase arm-tune.md and invoke.texi, these were all obvious
changes.
I'm seeing a DejaGNU error while testing
RUNTESTFLAGS="arm.exp=pr45701-*.c":
ERROR: (DejaGnu) proc "^-" does not exist.
The error code is NONE
The info on the error is:
invalid command name "^-"
     while executing
"::tcl_unknown ^-"
     ("uplevel" body line 1)
     invoked from within
"uplevel 1 ::tcl_unknown $args"

That's due to the scan-assembler-not test:
/* { dg-final { scan-assembler-not "[^\-]r8" } } */

The '[' and ']' need to be escaped by a backslash.
Can you please post a patch to add the escapes.
Sorry for missing this in the original review...

Kyrill

Cheers,
Andre

Hi there,

Sorry for missing those too.

Looks ok.
Thanks,
Kyrill

2016-03-09 Andre Vieira <andre.simoesdiasvieira@arm.com>

* gcc.target/arm/pr45701-1.c: Escape brackets.
* gcc.target/arm/pr45701-2.c: Likewise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]