This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [hsa, testsuite] Suppress hsa warnings in libgomp tests
- From: Martin Jambor <mjambor at suse dot cz>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 4 Mar 2016 16:27:11 +0100
- Subject: Re: [hsa, testsuite] Suppress hsa warnings in libgomp tests
- Authentication-results: sourceware.org; auth=none
- References: <20160226155957 dot GJ3094 at virgil dot suse dot cz> <20160226160756 dot GF3017 at tucnak dot redhat dot com> <20160301183918 dot GA2148 at virgil dot suse dot cz> <20160301184749 dot GH3017 at tucnak dot redhat dot com> <20160301214746 dot GA14713 at virgil dot suse dot cz> <20160301220643 dot GJ3017 at tucnak dot redhat dot com>
Hi,
On Tue, Mar 01, 2016 at 11:06:43PM +0100, Jakub Jelinek wrote:
> On Tue, Mar 01, 2016 at 10:47:46PM +0100, Martin Jambor wrote:
> > well, exactly what I wrote in the original email and what you have
> > quoted (and me as well) above. But let me quote the dejagnu source
> > comment of dg-runtest, which is perhaps more clear:
> >
> > # FLAGS is a set of options to always pass.
> > # DEFAULT_EXTRA_FLAGS is a set of options to pass if the testcase
> > # doesn't
> > # specify any (with dg-option).
> >
> > So if I changed DEFAULT_EXTRA_FLAGS rather than FLAGS, I'd have to go
> > through all testcases specifying dg-options and add -Wno-hsa there
> > too. Moreover, we'd have to add -Wno-hsa to all appropriate future
> > testcases if they specify their own dg-options.
>
> Ah, ok; what about adding
> # Disable HSA warnings by default.
> lappend ALWAYS_CFLAGS "additional_flags=-Wno-hsa"
> in libgomp/testsuite/lib/libgomp.exp (next to e.g.
> -fno-diagnostics-show-caret)?
>
That works nicely (though I have to override it explicitely in the
libgomp.hsa.c directory with another -Whsa, but I guess we can live
with that). So I will use the above for the libgomp case.
I have tried to come up with a similar alternative for
gcc.dg/gomp/gomp.exp, g++.dg/gomp/gomp.exp and gfortran/gomp/gomp.exp
but so far I have not achieved to make the C++ and Fortran cases work
in any other way but pass -Wno-hsa in FLAGS (and thus change the
name). For C, adding the following before the main loop works, even
though it looks too much like a hack to me:
global TEST_ALWAYS_FLAGS
set TEST_ALWAYS_FLAGS [concat $TEST_ALWAYS_FLAGS "-Wno-hsa"]
However, the C++ and Fortran cases use gfortran-dg-runtest to cycle
through a set of torture options and I have not yet discovered the
right magic variable to set (for example, adding -Wno-hsa to
DG_TORTURE_OPTIONS elements does not work).
I'm afraid I have spent way too much time on this already, so unless
someone has any ideas, I'd suggest that we use the (already approved)
name-changing gomp patch as it is. Or at least for C++ and Fortran.
Thanks,
Martin