This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix vec_set_hi* patterns (PR target/70059)
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 4 Mar 2016 17:42:25 +0300
- Subject: Re: [PATCH] Fix vec_set_hi* patterns (PR target/70059)
- Authentication-results: sourceware.org; auth=none
- References: <20160303120841 dot GC3017 at tucnak dot redhat dot com> <20160303201748 dot GO3017 at tucnak dot redhat dot com>
On 03 Mar 21:17, Jakub Jelinek wrote:
> On Thu, Mar 03, 2016 at 01:08:41PM +0100, Jakub Jelinek wrote:
> > Fixed thusly, unfortunately I don't have access to avx512f (and not even to
> > avx512dq) hw, so while I will bootstrap/regtest it on Haswell-E, can't test
> > the tests if they now work at runtime (they link and the assembly of the foo
> > routine has changed and looks good to me). Can somebody test this please
> > on real hw or emulator?
> > Ok for trunk if it passes?
This is definetely copy-and-paste issue. OK for trunk and branches (although
in 4_9 only 1 pattern affected).
Thanks for catching this!
> FYI, my bootstrap/regtest on Haswell-E (but without trying to run any
> AVX512-* code, just link it at most) passed on both x86_64-linux and
> i686-linux.
Checked on skylake-avx512 simulator:
$ ./*-ref/src/gcc/contrib/compare_tests *-ref/bld/ *-exp/bld
# Comparing directories
## Dir1=31153-pr70059-ref/bld/: 3 sum files
## Dir2=15951-pr70059-exp/bld: 3 sum files
# Comparing 3 common sum files
## /bin/sh ./31153-pr70059-ref/src/gcc/contrib/compare_tests /tmp/gxx-sum1.21498 /tmp/gxx-sum2.21498
New tests that PASS:
gcc.target/i386/avx512dq-pr70059.c (test for excess errors)
gcc.target/i386/avx512dq-pr70059.c execution test
gcc.target/i386/avx512f-pr70059.c (test for excess errors)
gcc.target/i386/avx512f-pr70059.c execution test
# No differences found in 3 common sum files
>
> > 2016-03-03 Jakub Jelinek <jakub@redhat.com>
> >
> > PR target/70059
> > * config/i386/sse.md (vec_set_lo_<mode><mask_name>,
> > <extract_type_2>_vinsert<shuffletype><extract_suf_2>_mask): Formatting
> > fixes.
> > (vec_set_hi_<mode><mask_name>): Likewise. Swap VEC_CONCAT operands.
> >
> > * gcc.target/i386/avx512f-pr70059.c: New test.
> > * gcc.target/i386/avx512dq-pr70059.c: New test.
>
> Jakub
--
K