This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences
- From: Martin LiÅka <mliska at suse dot cz>
- To: Richard Biener <richard dot guenther at gmail dot com>, Mikhail Maltsev <maltsevm at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches mailing list <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 24 Feb 2016 15:16:54 +0100
- Subject: Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences
- Authentication-results: sourceware.org; auth=none
- References: <56130763 dot 4070206 at gmail dot com> <563673C7 dot 2030607 at gmail dot com> <5637F356 dot 7080306 at redhat dot com> <563A1E2F dot 9030309 at gmail dot com> <CAFiYyc3AWhtT46ZvKtvEWH-xXqgfdAvx99a8+zBjfupw01sN7A at mail dot gmail dot com>
On 02/23/2016 04:21 PM, Richard Biener wrote:
> On Wed, Nov 4, 2015 at 4:03 PM, Mikhail Maltsev <maltsevm@gmail.com> wrote:
>> On 11/03/2015 02:35 AM, Jeff Law wrote:
>>> This is good fore the trunk too. Please install.
>>>
>>> Thanks!
>>>
>>> jeff
>>
>> Committed as r229758.
>
>> grep ENABLE_CHECKING *.[ch]
> dwarf2out.c:#if ENABLE_CHECKING
> dwarf2out.c:#if ENABLE_CHECKING
> dwarf2out.c:#if ENABLE_CHECKING
> dwarf2out.h:#if ENABLE_CHECKING
Hi Richi.
Removal in dwarf2out.c is not possible due to assignment (and read) of
a struct member that is conditional in dwarf2out.h:
struct GTY((chain_next ("%h.dw_loc_next"))) dw_loc_descr_node {
...
#if ENABLE_CHECKING
/* When translating a function into a DWARF procedure, contains the frame
offset *before* evaluating this operation. It is -1 when not yet
initialized. */
int dw_loc_frame_offset;
#endif
};
> hsa-gen.c:#ifdef ENABLE_CHECKING
> hsa-regalloc.c:#ifdef ENABLE_CHECKING
>> grep ENABLE_CHECKING ada/gcc-interface/*.[ch]
> ada/gcc-interface/utils.c:#ifdef ENABLE_CHECKING
I've just prepared patches for remaining files., btw. is it an acceptable stage4 material?
Thanks,
Martin
>
>
>> --
>> Regards,
>> Mikhail Maltsev