This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bootstrap on m68k (PR target/69885)


On 02/22/2016 06:08 AM, Jakub Jelinek wrote:
Hi!

Supposedly my recent invalid shift count expansion changes broke
m68k bootstrap, we now really require that the shift expanders
have some non-VOIDmode, so that we can convert_mode it to that
mode.  But m68k didn't specify mode.  For valid shift counts
the patch makes no difference beyond fixing the ICE, those are
all CONST_INTs which when converted to CONST_INTs valid for
SImode give the same values.

Fixed thusly, Matthias has kindly tested it on m68k-linux, ok for trunk?

2016-02-22  Jakub Jelinek  <jakub@redhat.com>

	PR target/69885
	* config/m68k/m68k.md (ashldi3, ashrdi3, lshrdi3): Use
	SImode for last match_operand.

	* gcc.dg/pr69885.c: New test.
OK for the trunk. Can you take a peek at other ports and see if any have the same issue? It wouldn't surprise me if some of the older ports did. If so, similar patches for other ports are pre-approved.

It also seems like an update for md.texi is in order. That can be handled as a pre-approved follow-up as well.

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]