This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix expansion of TREE_ADDRESSABLE bitwise copies (PR c++/69851)
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Bernd Schmidt <bschmidt at redhat dot com>, Eric Botcazou <ebotcazou at adacore dot com>, "jason at redhat dot com" <jason at redhat dot com>
- Date: Fri, 19 Feb 2016 20:45:09 +0000
- Subject: Re: [PATCH] Fix expansion of TREE_ADDRESSABLE bitwise copies (PR c++/69851)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=hotmail.de;
- References: <HE1PR07MB09059275EE2C48C99026F453E4A00 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com> <20160219190447 dot GX3017 at tucnak dot redhat dot com> <HE1PR07MB09058787595F6611848CA63DE4A00 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com> <20160219200842 dot GZ3017 at tucnak dot redhat dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
Excuse me,
I have still another question.
Why are you adding braces here?
+ || (bitsize % BITS_PER_UNIT != 0)
+ || (bitpos % BITS_PER_UNIT != 0)
+ || (compare_tree_int (DECL_SIZE (TREE_OPERAND (exp, 1)), bitsize)
+ != 0)))
I think everywhere in that function we omit braces around == terms
inside || terms even long ones.
|| a == b
|| c == d
|| e == f)
I know many like to add braces here, but GCC does not do that
unnecessarily, right?
Thanks
Bernd.