This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] combine: Delete EQ* notes when pseudo mode changes (PR60818)
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 19 Feb 2016 13:14:55 -0600
- Subject: Re: [PATCH] combine: Delete EQ* notes when pseudo mode changes (PR60818)
- Authentication-results: sourceware.org; auth=none
- References: <71ce2561d2dd574e38b062a094f4ce41cac21a84 dot 1455873752 dot git dot segher at kernel dot crashing dot org> <2273932 dot axMRkiNLzf at polaris> <20160219114354 dot GA25674 at gate dot crashing dot org> <48532907 dot mTifRsJ0uM at polaris>
On Fri, Feb 19, 2016 at 07:39:03PM +0100, Eric Botcazou wrote:
> > Not for stage 4 certainly.
>
> If we go this way, is the bug a regression? If no, why rushing the fix?
It is not a regression (it is in all open release branches already).
I can postpone it if you think that is wiser?
> > That moves those notes to i2notes, and then distribute_notes drops them?
>
> That's not why I understand though. The code appends i2notes to i3notes and
> distribute_notes will preserve them on i3:
I misread it as moving the notes from i3 to i2, ugh. It looks like we
do have a problem if i2 is a parallel with only one SET; but we already
had a problem anyway? The REG_EQ* is put on the wrong insn?
Segher