This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][CilkPlus] Fix PR69363
- From: Markus Trippelsdorf <markus at trippelsdorf dot de>
- To: Ilya Verbin <iverbin at gmail dot com>
- Cc: Marek Polacek <polacek at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Wed, 17 Feb 2016 16:34:08 +0100
- Subject: Re: [PATCH][CilkPlus] Fix PR69363
- Authentication-results: sourceware.org; auth=none
- References: <20160217143258 dot GA31394 at msticlxl57 dot ims dot intel dot com> <20160217144600 dot GG3017 at tucnak dot redhat dot com> <20160217150814 dot GB31394 at msticlxl57 dot ims dot intel dot com> <20160217151144 dot GW3163 at redhat dot com> <20160217151422 dot GH3017 at tucnak dot redhat dot com> <20160217152834 dot GX3163 at redhat dot com> <20160217152928 dot GC31394 at msticlxl57 dot ims dot intel dot com>
On 2016.02.17 at 18:29 +0300, Ilya Verbin wrote:
> On Wed, Feb 17, 2016 at 16:28:34 +0100, Marek Polacek wrote:
> > On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote:
> > > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote:
> > > > On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote:
> > > > > > This line is too long. But you could have just done
> > > > >
> > > > > My editor shows exactly 80 chars.
> > > >
> > > > The maximum is 79.
> > >
> > > Well, check_GNU_style.sh complains just about one line, and then
> > > a prototype.
> > >
> > > Lines should not exceed 80 characters.
> > > 193:+extern tree finish_omp_clauses (tree, bool, bool = false, bool = false);
> > > 252:+ error ("linear clause applied to non-integral non-pointer "
> >
> > Maybe it should be fixed with this then. Because
> > <https://www.gnu.org/prep/standards/standards.html#Formatting> says
> > "Please keep the length of source lines to 79 characters or less, for maximum
> > readability in the widest range of environments."
>
> https://gcc.gnu.org/codingconventions.html#Line says 80.
gcc % cat contrib/clang-format | grep ColumnLimit
ColumnLimit: 80
--
Markus