This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: Yuri Rumyantsev <ysrumyan at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, nd at arm dot com, Uros Bizjak <ubizjak at gmail dot com>, ÐÐÑÑ ÐÐÐÐÐÐÑ <enkovich dot gnu at gmail dot com>, Igor Zamyatin <izamyatin at gmail dot com>
- Date: Mon, 8 Feb 2016 15:24:14 +0100
- Subject: Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump
- Authentication-results: sourceware.org; auth=none
- References: <CAEoMCqQc_kbYCHzd6241EPP7oZExA7MYKPA5Y-DaVnMYJL3LPA at mail dot gmail dot com> <1454936845-18517-1-git-send-email-james dot greenhalgh at arm dot com> <CAEoMCqTGFs71QaJYof96ix=v_AOUmf=TLEs4hMa3LmDhUOjJ4w at mail dot gmail dot com> <20160208134024 dot GA19031 at arm dot com>
On Mon, Feb 8, 2016 at 2:40 PM, James Greenhalgh
<james.greenhalgh@arm.com> wrote:
> On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote:
>> Hi James,
>>
>> Thanks for reporting this issue.
>> I prepared slightly different patch since we don't need to add
>> tree-vect dump option - it is on by default for all tests in /vect
>> directory.
>
> Hm, I added that line as my test runs were showing:
>
> UNRESOLVED: gcc.dg/vect/vect-mask-store-move-1.c: dump file does not exist
>
> I would guess the explicit
>
> /* { dg-options "-O3" } */
>
> is clobbering the vect.exp setup of flags?
Yes. Use { dg-additional-options "-O3" } instead.
> This also affects the x86-64 results H.J. Lu is sending out:
>
> https://gcc.gnu.org/ml/gcc-testresults/2016-02/msg00824.html
>
> Thanks,
> James
>
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.dg/vect/vect-mask-store-move-1.c: Gate dump with x86 target.
>>
>> 2016-02-08 16:07 GMT+03:00 James Greenhalgh <james.greenhalgh@arm.com>:
>> >
>> > Hi,
>> >
>> > As far as I can tell, this testcase will only vectorize for x86_64/i?86
>> > targets, so it should be gated to only check for vectorization on those.
>> >
>> > Additionally, this test wants to scan the vectorizer dumps, so we ought
>> > to add -fdump-tree-vect-all to the options.
>> >
>> > Checked on aarch64 (cross/native) and x86 with no issues.
>> >
>> > OK?
>> >
>> > Thanks,
>> > James
>> >
>> > ---
>> > 2016-02-08 James Greenhalgh <james.greenhalgh@arm.com>
>> >
>> > * gcc.dg/vect/vect-mask-store-move-1.c: Add dump option, and gate
>> > check on x86_64/i?86.
>> >
>
>